[cpia] 2.4.0-test5-pre5 compile warning in cpia.c (fwd)

[Johannes Erdfelt]

Looks reasonable to me.

JE

----- Forwarded message from Rasmus Andersen <rasmus@diku.dk> -----

From: Rasmus Andersen <rasmus@diku.dk>
Subject: 2.4.0-test5-pre5 compile warning in cpia.c
To: jerdfelt@sventech.com
Date: Tue, 25 Jul 2000 23:45:44 +0200 (METDST)
X-Mailer: ELM [version 2.4ME+ PL66 (25)]

Hi.

(I'm not sure that you are the maintainer for drivers/char/cpia.c so
please accept my apologies if you are not.)

When compiling cpia-support in-kernel (CONFIG_VIDEO_CPIA=y) I get the
following warning:

cpia.c:1298: warning: `proc_cpia_destroy' defined but not used

Since this function is only used when the code is compiled and used as
a module the following patch places the (hopefully) correct #ifdefs:


--- drivers/char/cpia.c.org	Tue Jul 25 23:25:09 2000
+++ drivers/char/cpia.c.new	Tue Jul 25 23:25:47 2000
@@ -1294,10 +1294,12 @@
 		LOG("Unable to initialise /proc/cpia\n");
 }
 
+#ifdef MODULE
 static void proc_cpia_destroy(void)
 {
 	remove_proc_entry("cpia", 0);
 }
+#endif /*MODULE*/
 #endif /* CONFIG_PROC_FS */
 
 /* ----------------------- debug functions ---------------------- */


Regards,
        Rasmus(rasmus@diku.dk)

An Emacs reference mug is what I want. It would hold ten gallons of
coffee. -- Steve VanDevender 


----- End forwarded message -----